Fix DisposalUnit deletes enitites that climbing inside in special timing#43686
Open
M4rchy-S wants to merge 1 commit intospace-wizards:masterfrom
Open
Fix DisposalUnit deletes enitites that climbing inside in special timing#43686M4rchy-S wants to merge 1 commit intospace-wizards:masterfrom
M4rchy-S wants to merge 1 commit intospace-wizards:masterfrom
Conversation
PJBot
added
S: Untriaged
M4rchy-S
changed the title
Tayrtahn
reviewed
Apr 22, 2026
| private void OnDoAfter(EntityUid uid, DisposalUnitComponent component, DoAfterEvent args) | ||
| { | ||
| if (args.Handled || args.Cancelled || args.Args.Target == null || args.Args.Used == null) | ||
| if (args.Handled || args.Cancelled || args.Args.Target == null || args.Args.Used == null || component.IsDestroyed) |
Member
There was a problem hiding this comment.
Would TerminatingOrDeleted work instead?
Contributor
Author
There was a problem hiding this comment.
I checked TerminatingOrDeleted and it does not work.
Pok27
added
T: Bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Closes: #43541
Why / Balance
Critical bug.
Technical details
Bug occurs because of race conditions between OnDestruction and OnDoAfter functions.
Added special flag in component to detect disposal unit deletion.
Requirements
Breaking changes
Changelog
🆑